Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed form matcher specs #13

Merged
merged 1 commit into from
Sep 24, 2017
Merged

Fixed form matcher specs #13

merged 1 commit into from
Sep 24, 2017

Conversation

Fedcomp
Copy link
Contributor

@Fedcomp Fedcomp commented Sep 22, 2017

This fixes failing tests in master. Possibly related to #12 馃槈
Rspec errors:

1) form matchers #have_field for form with invalid field return false
   Failure/Error: Hanami::Action::Params.new({})
   
   NoMethodError:
     undefined method `call' for nil:NilClass
     Did you mean?  caller
   # /home/user/.rvm/gems/ruby-2.3.1/gems/hanami-validations-1.0.0/lib/hanami/validations.rb:360:in `validate'
   # /home/user/.rvm/gems/ruby-2.3.1/gems/hanami-controller-1.0.1/lib/hanami/action/params.rb:72:in `initialize'
   # ./spec/support/views.rb:9:in `new'
   # ./spec/support/views.rb:9:in `params'
   # /home/user/.rvm/gems/ruby-2.3.1/gems/hanami-helpers-1.0.0/lib/hanami/helpers/form_helper/form_builder.rb:118:in `initialize'
   # /home/user/.rvm/gems/ruby-2.3.1/gems/hanami-helpers-1.0.0/lib/hanami/helpers/form_helper.rb:418:in `new'
   # /home/user/.rvm/gems/ruby-2.3.1/gems/hanami-helpers-1.0.0/lib/hanami/helpers/form_helper.rb:418:in `form_for'
   # ./spec/support/views.rb:13:in `form'
   # ./spec/rspec/hanami/matchers/form_matchers_spec.rb:64:in `block (4 levels) in <top (required)>'

Rspec command to reproduce:

rspec ./spec/rspec/hanami/matchers/form_matchers_spec.rb:63 # form matchers #have_field for form with invalid field return false

Copy link
Owner

@davydovanton davydovanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for me, thanks!

@davydovanton davydovanton merged commit 55a44f6 into davydovanton:master Sep 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants