New realisation for thread safe history middleware

[davydovanton]

No description provided.

[davydovanton]

@mperham I added test for checking thread-safe in middleware. Also I used redis transaction (watch and multi methods) for fixing my history storage. What do you think, it's normal for you?

[mperham]

This is safer but it's not performant at all. The issue is that you're still using Sidekiq.load_json to store a hash as a string rather than using Redis' native Hash commands. You want to use something like:

Sidekiq.redis do |c|
  c.multi do
    c.hincrby(history_key, "runtime_ms", job_time_in_ms)
    c.hmset(history_key, "last_status", "passed", "last_runtime", Time.now.utc.to_i)
  end
end

Read through the Hash commands and figure out what you need to do to remove Sidekiq.load_json.

[davydovanton]

Okay, I understood you, thanks for review! 🤘

[davydovanton]

@mperham I'll change hash serialization to native redis hash in separate PR.