Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with latest v2.24.1: Cannot read properties of undefined #207

Closed
ping opened this issue Nov 9, 2022 · 2 comments
Closed

Error with latest v2.24.1: Cannot read properties of undefined #207

ping opened this issue Nov 9, 2022 · 2 comments

Comments

@ping
Copy link
Contributor

ping commented Nov 9, 2022

I'm getting errors for this action with the latest v2.24.1. No error when pinned to the previous version (2.24.0).

##[debug]Evaluating condition for step: 'Download meta artifacts'
##[debug]Evaluating: success()
##[debug]Evaluating success:
##[debug]=> true
##[debug]Result: true
##[debug]Starting: Download meta artifacts
##[debug]Loading inputs
##[debug]Evaluating: github.token
##[debug]Evaluating Index:
##[debug]..Evaluating github:
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'token'
##[debug]=> '***'
##[debug]Result: '***'
##[debug]Evaluating: github.repository
##[debug]Evaluating Index:
##[debug]..Evaluating github:
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'repository'
##[debug]=> 'ping/newsrack'
##[debug]Result: 'ping/newsrack'
##[debug]Loading env
Run dawidd6/action-download-artifact@v2
  with:
    name: meta-artifacts
    path: meta
    search_artifacts: true
    if_no_artifact_found: warn
    github_token: ***
    workflow_conclusion: success
    repo: ping/newsrack
    check_artifacts: false
    skip_unpack: false
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.10.8/x64
    PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.10.8/x64/lib/pkgconfig
    Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.8/x64
    Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.8/x64
    Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.8/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.10.8/x64/lib
    calibre_ver: 6.8.0
==> Repository: ping/newsrack
==> Artifact name: meta-artifacts
==> Local path: meta
==> Workflow name: 24150399
==> Workflow conclusion: success
Error: Cannot read properties of undefined (reading 'artifacts')
##[debug]Node Action run completed with exit code 1
##[debug]Set output found_artifact = false
##[debug]Set output error_message = Cannot read properties of undefined (reading 'artifacts')
##[debug]Finishing: Download meta artifacts
@jamesmortensen
Copy link
Contributor

This broke our workflows. I had to downgrade to 2.24.0 and rerun with workflow_dispatch. Seems that adding pagination must have created a problem somewhere. https://github.com/dawidd6/action-download-artifact/pull/205/files

From the error messages, I assume client.paginate is returning undefined and setting the artifacts variable as the same.

@dawidd6
Copy link
Owner

dawidd6 commented Nov 9, 2022

Reverted. Should be back to normal.

@dawidd6 dawidd6 closed this as completed Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants