-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
381 generate collision contacts #520
base: master
Are you sure you want to change the base?
Conversation
if (translation == Vector2.Zero) | ||
{ | ||
mtv = new MinimumTranslationVector(Vector2.UnitX, penetrationDepth); | ||
} | ||
else | ||
{ | ||
mtv = new MinimumTranslationVector(translation.Unit, penetrationDepth); | ||
} |
Check notice
Code scanning / CodeQL
Missed ternary opportunity Note
if (mtv1.Length < mtv2.Length) | ||
{ | ||
mtv = mtv1; | ||
} | ||
else | ||
{ | ||
mtv = new MinimumTranslationVector(mtv2.Direction.Opposite, mtv2.Length); | ||
} |
Check notice
Code scanning / CodeQL
Missed ternary opportunity Note
@@ -80,7 +79,30 @@ | |||
CreateCamera(); | |||
CreatePoint(0, 0); | |||
|
|||
CreateKinematicBody(0, 0); | |||
var entityController = CreateEntityController(); |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
No description provided.