Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stuck Converting #36

Closed
dshepsis opened this issue Jun 4, 2018 · 16 comments
Closed

Stuck Converting #36

dshepsis opened this issue Jun 4, 2018 · 16 comments

Comments

@dshepsis
Copy link

dshepsis commented Jun 4, 2018

I attempted three times to convert different image files (JPG and PNG) and each time, after hitting the "Merge" button, the window changed to "Converting" and stayed that way for several minutes before I manually closed the application via the Windows Task Manager.

I'm using Windows 10.

I've deleted the software out of frustration so I can't do any more testing to figure out the cause, but I can provide more information on my system if it would help.

@ericadamski
Copy link
Contributor

ericadamski commented Jun 4, 2018

@dshepsis thank you for taking the time to open an issue here so that we an make Alchemy better for other people!

If it is possible could you send the file names and types you tried to convert?

Could you also let me know what version of Alchemy you had?

@YukariTea
Copy link

Same issue here, Alchemy 0.5.0., tried merging png and jpg files into a pdf, any combination gets stuck on conversion screen.

@ericadamski
Copy link
Contributor

Thank you for submitting!

Are you using Windows as well? Do the file names have any special characters in them? Just trying to workout a connection between other bugs 😁

@YukariTea
Copy link

Filenames are named 001, 002, etc., no special characters. This was tested on Windows.

@ericadamski
Copy link
Contributor

@YukariTea thank you!

@ericadamski
Copy link
Contributor

To re-create this issue:

  1. Select a combination of formats to convert
  2. Select convert option

screen shot 2018-06-26 at 7 02 57 am

@briandennis
Copy link
Member

@ericadamski was that error generated on Windows?

@ericadamski
Copy link
Contributor

@briandennis nope, that was on my Mac.

@mfix22
Copy link
Member

mfix22 commented Jun 26, 2018 via email

@briandennis
Copy link
Member

@mfix22 what do you mean? Can you point me to what you think may be the problem?

@briandennis
Copy link
Member

@ericadamski could you upload the files that triggered the error?

@ericadamski
Copy link
Contributor

16926704
img_4806
screen shot 2018-06-25 at 3 41 19 pm

here you are @briandennis

@briandennis
Copy link
Member

I don't think the problem is that you're converting different formats at the same time. Rather, I think it's that some of the files have the same input format as your output format (it's converting jpgs to jpg). Or at least, that was the only way I was able to repeat the error — converting all of your images worked fine for me so long as the output type wasn't jpg or png (tested both both a build from source and pulling the current brew cask).

Does that sound like it could be the culprit? 🤔

@mfix22
Copy link
Member

mfix22 commented Jun 27, 2018

@briandennis I have seen that issue before. Either way we should just ignore conversions like that as to not have errors blow the whole operation.

ericadamski added a commit that referenced this issue Jun 27, 2018
Fixes #36, closes #43

Logic now filters out any types that overlap in the coversion types and the files to covert
mfix22 pushed a commit that referenced this issue Jun 27, 2018
* Ignore all file types being converted as potential outputs

Fixes #36, closes #43

Logic now filters out any types that overlap in the coversion types and the files to covert

* Make and use a helper for some of the duplication

* Fix typo 😬, add test

* Remove package-lock.json

* Remove yarn-error.log
@briandennis
Copy link
Member

I'm fine closing this if you guys want to, but we should look into the original issues.

I attempted three times to convert different image files (JPG and PNG) and each time, after hitting the "Merge" button, the window changed to "Converting" and stayed that way for several minutes before I manually closed the application via the Windows Task Manager.
I'm using Windows 10.

and

Same issue here, Alchemy 0.5.0., tried merging png and jpg files into a pdf, any combination gets stuck on conversion screen. Filenames are named 001, 002, etc., no special characters. This was tested on Windows.

both appear to be a distinct from the issue fixed by #44

@ericadamski
Copy link
Contributor

Agreed @briandennis

This is out of my scope, I have no access to a Windows machine.

I am totally into helping implement the solution, upon finding the source of the issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants