Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapsible "Advanced" settings #148

Merged
merged 3 commits into from
Dec 16, 2017
Merged

Collapsible "Advanced" settings #148

merged 3 commits into from
Dec 16, 2017

Conversation

mfix22
Copy link
Contributor

@mfix22 mfix22 commented Dec 15, 2017

screen recording

@mfix22 mfix22 requested a review from jakedex December 15, 2017 04:00
@jakedex
Copy link
Collaborator

jakedex commented Dec 15, 2017

Hell yes, thanks for cleaning this up. Could you add a dropdown arrow to the Collapse element? Also, how do you feel about changing 'width adjustment' to something like 'auto width'?

@mfix22
Copy link
Contributor Author

mfix22 commented Dec 16, 2017

@jakedex
screenshot 2017-12-15 19 02 19

jakedex
jakedex approved these changes Dec 16, 2017
View reviewed changes
Copy link
Collaborator

@jakedex jakedex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to break dependency updates off into another CR and do proper testing? Up to you.

@mfix22 mfix22 merged commit ac28311 into master Dec 16, 2017
@mfix22 mfix22 deleted the collapsible branch December 16, 2017 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakedex jakedex jakedex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfix22 @jakedex