Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add excludeExtensions #14

Merged
merged 2 commits into from
Jan 8, 2017
Merged

Add excludeExtensions #14

merged 2 commits into from
Jan 8, 2017

Conversation

kristofferremback
Copy link
Contributor

@kristofferremback kristofferremback commented Dec 15, 2016

Adds support for excluding extensions specified in the settings file. By default .js excluded.

Extensions in the list are case insensitive, and including the dot is optional. In the below example, files ending with .js and .jsx are excluded, but all other extensions are left in.

Edit: This closes #13

{
    "relativePath.removeLeadingDot": true,
    "relativePath.ignore": [
        "**/node_modules/**",
        "**/*.dll",
        "**/obj/**",
        "**/objd/**",
        "**/dist/**"
    ],
    "relativePath.removeExtension": false,
    "relativePath.excludedExtensions": [
        "js",
        ".JSX"
    ]
  }

@jakob101
Copy link
Collaborator

Looks good. I'm gonna check it out, test it and publish over the weekend :) thanks man!

@kristofferremback
Copy link
Contributor Author

Excellent, this was fun! I noticed settings are loaded only once, meaning updates to the settings file require users to run Reload Window or restart the application. I might have a stab at that too if you don't mind?

@jakob101
Copy link
Collaborator

jakob101 commented Dec 16, 2016 via email

@kristofferremback
Copy link
Contributor Author

To keep PRs small I made another PR for keeping configuration up-to-date #15

@kristofferremback
Copy link
Contributor Author

@jakob101 Any status on this? Anything I can do?

@jakob101
Copy link
Collaborator

jakob101 commented Dec 30, 2016 via email

@kristofferremback
Copy link
Contributor Author

Super, enjoy your vacation!

@jakob101 jakob101 merged commit 35f7e49 into dawsbot:master Jan 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Remove only some extensions
2 participants