🧪 mocking in get-block #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawsbot
requested changes
May 10, 2023
| import { mockOf } from '../mock-of'; | ||
| import { hexToDecimal } from '../../../classes/utils/hex-to-decimal'; | ||
|
|
||
| jest.mock('isomorphic-unfetch'); | ||
|
|
||
| // RSK has 30 second block times so tests pass more often | ||
| const rpcUrl = `https://public-node.rsk.co`; |
There was a problem hiding this comment.
Let's remove this line entirely @jtfirek
There was a problem hiding this comment.
By remove do you mean replace with const rpcUrl = rpcUrls.mainnet; @dawsbot?. I thought that we need some rpcURL for testing the providers?
There was a problem hiding this comment.
When we're all done with our test changes with spys and mocks, all tests should work in an offline environment @jtfirek
dawsbot
reviewed
May 10, 2023
| ]; | ||
| omittableOther = [...typeCheckKeys]; | ||
| } | ||
| async function runTest(method: any, params: any[], responseIdentifier: string | number): Promise<void> { |
There was a problem hiding this comment.
I fixed by adding an export from type from the library @dawsbot, but lmk if this is not allowing as I could also just define a simple type for this test I just thought that importing would be cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mocking in
get-block.test.tsand slight changes inget-transactions.test.tsjust to make tests consistent across files