🧼 cleaning out ethers from utils/tests/bytes
#237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawsbot
reviewed
May 22, 2023
| const inputs: ReadonlyArray<BytesLikeWithNumber[]> = [[0, 1]]; | ||
|
|
||
| inputs.forEach((input) => { | ||
| expect(concat(input)).toStrictEqual(ethers.utils.concat(input as any)); | ||
| expect(concat(input)).toStrictEqual(new Uint8Array([0, 1])); |
dawsbot
requested changes
May 22, 2023
| it('should match expected slice - hexadecimal strings', () => { | ||
| const hexValues = ['0x123456']; | ||
| hexValues.forEach((hexValue) => { | ||
| expect(hexDataSlice(hexValue, 0, 2)).toStrictEqual('0x1234'); |
There was a problem hiding this comment.
I think your IDE is missing critical information eslint integration
There was a problem hiding this comment.
@dawsbot mmmm trying to replicate this on my machine. I'll just be careful for now till I have time to git this linter in my IDE on my own time.
dawsbot
reviewed
May 22, 2023
| expect(() => hexlify(value as BytesLike)).toThrow( | ||
| 'invalid hexlify value', | ||
| ); | ||
| expect(() => hexlify(value as BytesLike)).toThrow('invalid hexlify value'); |
There was a problem hiding this comment.
Try to never type-cast like this. Instead we should prefer typing at the point of defining the value. Here's why:
There was a problem hiding this comment.
Ok! so as a general rule of thumb never bypass the type checker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dawsbot ik you like prs to be shorter, but these changes are very simple. I thought it would just be easier to put them in one pr.
