Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for additional python versions #96

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

Raj725
Copy link
Collaborator

@Raj725 Raj725 commented Feb 1, 2024

Support for additional Python versions:

  1. 3.10
  2. 3.12
  3. 3.9

Update torch dependency version to include newer versions(Python 3.12).
Error log:
pebblo/.pebblo_39/lib/python3.9/site-packages/spacy/schemas.py", line 287, in <module>
    class TokenPattern(BaseModel):
  File "pydantic/main.py", line 198, in pydantic.main.ModelMetaclass.__new__
  File "pydantic/fields.py", line 506, in pydantic.fields.ModelField.infer
  File "pydantic/fields.py", line 436, in pydantic.fields.ModelField.__init__
  File "pydantic/fields.py", line 552, in pydantic.fields.ModelField.prepare
  File "pydantic/fields.py", line 661, in pydantic.fields.ModelField._type_analysis
  File "pydantic/fields.py", line 668, in pydantic.fields.ModelField._type_analysis
  File "/usr/lib/python3.9/typing.py", line 852, in __subclasscheck__
    return issubclass(cls, self.__origin__)
TypeError: issubclass() arg 1 must be a class
@Raj725 Raj725 self-assigned this Feb 1, 2024
@Raj725 Raj725 marked this pull request as ready for review February 2, 2024 07:37
@Raj725 Raj725 requested a review from srics February 2, 2024 07:38
@sridhar-daxa sridhar-daxa added the lgtm Looks good and ready to merge label Feb 2, 2024
Copy link
Collaborator

@srics srics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srics srics merged commit 760bf6c into daxa-ai:main Feb 2, 2024
2 checks passed
@Raj725 Raj725 mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants