Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the shares_float and shares_float/all API #36

Merged
merged 4 commits into from
Dec 16, 2023
Merged

Conversation

Kasamuri
Copy link
Contributor

Hello Everyone,
I've added the shares-float and shares-float/all
as available endpoints.

Since this is my first contribution to Open-Source please let me know,
if i messed something up :)

@daxm
Copy link
Owner

daxm commented Dec 12, 2023

I think instead of having two methods, it should be a single method. Make the "all" as an optional boolean attribute that defaults to faults. What do you think?

@Kasamuri
Copy link
Contributor Author

That would certainly a way to do that while reducing the total amounts of endpoints.
I will get to that in the next couple of days :)

@daxm
Copy link
Owner

daxm commented Dec 16, 2023

Looks good!

@daxm daxm merged commit 0594a5e into daxm:master Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants