Add github action to run black on PRs and pushes to master #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set adds a github action which will run black in check mode against all pull requests and pushes to master. I have another PR I will open in a moment which blackifys the init.py file. Everything else was good. With this action in place PRs will report status on the workflow and it can be used as a merge gate.
To see it in action:
I updated master in my fork with the workflow. This is what a PR looks like when it passes:
ipl31#2 See the "show all checks" link.
Here are the details on the workflow execution: https://github.com/ipl31/fmpsdk/pull/2/checks?check_run_id=1933517932
Here is an example of a previous workflow on my fork that failed before I fixed the black errors:
https://github.com/ipl31/fmpsdk/runs/1933483318