Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Fixup last PR #2

Merged
merged 6 commits into from
Jun 16, 2020
Merged

Fixup last PR #2

merged 6 commits into from
Jun 16, 2020

Conversation

Jake-Shadle
Copy link
Contributor

  • You accidentally merged my previous PR's submodule change, this corrects it to use the 0.3.2 branch of the official repo, sorry about that!
  • Fixed use after free bug(s) in Breadcrumb::new(), it would free the strings pointed at by both type and message, which would result in corrupted strings being sent to sentry, and sentry would apparently just completely swallow the event due the corrupted strings and not even report that there was an issue processing the event, oops!
  • Reimplemented the crappy workaround I did for adding stacktraces to the exception object on an event so that the stacktrace would show up nicely in sentry. You can use it like this:
let mut eve = Event::new();
eve.insert("level", "fatal");
eve.add_exception(sentry_native::Exception::new("panic", msg), 0);
eve.capture();

Let me know if you like that change and I can document the Exception object (right now it complains about missing docs).

@Jake-Shadle Jake-Shadle mentioned this pull request Jun 16, 2020
.gitmodules Show resolved Hide resolved
src/event.rs Outdated Show resolved Hide resolved
Co-authored-by: daxpedda <daxpedda@gmail.com>
@daxpedda daxpedda merged commit 7447898 into daxpedda:master Jun 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants