feat: 시청구간을 이용하여 미시청구간을 구하는 기능 추가 #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alstjs1207
requested review from
plainOldCode,
kimhr3001,
downmix,
youngjinmo,
akiraei,
yeonjoo7,
jo-seongjun and
hye-ung97
youngjinmo
reviewed
Jun 7, 2024
alstjs1207
commented
Jun 9, 2024
Comment on lines
+78
to
+85
| if (timeRange.length === 0) { | ||
| return [ | ||
| { | ||
| start: 0, | ||
| end: endTime, | ||
| }, | ||
| ]; | ||
| } |
There was a problem hiding this comment.
시청한 기록이 없다면 전체를 미시청 구간으로 전달하도록 추가하였습니다 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 의 종류는 어떤 것인가요?
수정이 필요하게된 이유가 무엇인가요? (Jira 이슈가 있다면 링크를 연결해주세요)
미시청구간을 구해야 한다.
무엇을 어떻게 변경했나요?
시청구간과 마지막클립 시간을 이용해 미시청 구간을 구합니다.
코드 변경을 이해하기 위한 배경지식이 필요하다면 설명 해주세요.
디펜던시 변경이 있나요?
어떻게 테스트 하셨나요?
test code
코드의 실행결과를 볼 수 있는 로그나 이미지가 있다면 첨부해주세요.