Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Component: Add on-drag-complete function to the API #4

Closed
ducky427 opened this issue Apr 13, 2015 · 3 comments
Closed

Split Component: Add on-drag-complete function to the API #4

ducky427 opened this issue Apr 13, 2015 · 3 comments

Comments

@ducky427
Copy link
Contributor

Hi,
I have a stateful reagent component as one the two panels in a h-split. When the splitter is dragged, I need to do some work to show the appropriate things [update some canvas updated animation].

Is it possible to pass an on-drag-complete function to a splitter? The default value could just be the identity function or you could check if the function if not nil and if so, call it.

It could possibly be called here: L146.

Thanks
@mike-thompson-day8
Copy link
Contributor

Notes:

  • this is a new optional parameter
  • I'm tempted to call it on-split-change.
  • it would be called with one, number parameter which is the new split-percentage
  • and yes, it would be called in stop-drag (after dragging has completed)
  • just to be clear: it would not be called initially, only if there is a change.
  • this modification to be made to both v-split and h-split in the same way.

If you agree, we'll put it in a release later today.

@ducky427
Copy link
Contributor Author

That makes sense to me. 👍

Gregg8 added a commit that referenced this issue Apr 14, 2015
@Gregg8
Version 0.5.0
1ff5284 
 - Issue #2 - Custom styling for labels for Tabs.
 - Also added the same support for the dropdown component.
 - Issue #4 - Split Component: Add on-drag-complete function to the API.
 - Also added class, style and attr parameters to both split components.
 - Pull request: Fixed usage example for scroller v-scroll variable.
 - Correct various working and spelling mistakes.
@ducky427
Copy link
Contributor Author

Works in v0.5.0.

Thanks a lot!

Gregg8 added a commit that referenced this issue Feb 4, 2021
@Gregg8
Cleaned up #4
ce2ac62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ducky427 @mike-thompson-day8