-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate using :npm-deps
to specify dependencies for Shadow CLJS users
#188
Comments
:npm-deps
to specify dependencies:npm-deps
to specify dependencies for Shadow CLJS users
No need to use If the Cljsjs packages used here (react-filp-move and react-highlight) are updated to use
The the same code will work with Cljsjs packages, ClojureScript compiler with Node modules and with Shadow-cljs. E.g create-react-class provides simple example of Cljsjs package which uses global-exports and provides the npm-style name: https://github.com/cljsjs/packages/blob/master/create-react-class/build.boot#L25-L27 (and for backwards comptilibity it also provides the old-style cljsjs.* name). Cljsjs wiki provides some more information on this: https://github.com/cljsjs/packages/wiki/Unified-module-names-and-global-exports Reagent 0.8.0 already uses this to access React, so that will work with all environments. |
@Deraen Not sure if that would interfere with standard CLJS compilation in any way though. |
Should be okay. ClojureScript compiler only uses |
Is there more required to properly fix this? |
We are using shadow-cljs with newer react versions and when you build the project with shadow it tries to npm install the versions in re-frame-10x deps.cljs. I couldn't find a way to prevent that, because shadow does not use the :install-deps compiler option (at least according to the docs) |
@talgiat Thanks for reporting. This has been fixed on |
#180 (comment)
We should look into how this works and what we can do to make things easier for Shadow users.
The text was updated successfully, but these errors were encountered: