Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show/hide hotkey in non-English layouts #207

Closed
achikin opened this issue May 25, 2018 · 2 comments · Fixed by #208
Closed

Show/hide hotkey in non-English layouts #207

achikin opened this issue May 25, 2018 · 2 comments · Fixed by #208

Comments

@achikin
Copy link
Contributor

achikin commented May 25, 2018

Ctrl-h shortcut does not work if non-english layout is active.

Steps to reproduce:

  1. Navigate to the app with re-frame-10x enabled
  2. Switch keyboard layout to a non-English one (in my case Russian)
  3. Press ctrl-h

Expected behavior:

re-frame-10x panel is shown/hidden

Actual behavior:

Nothing happens.

@achikin achikin changed the title Show/hide hotkey in non-English layouts. Show/hide hotkey in non-English layouts May 25, 2018
@achikin
Copy link
Contributor Author

achikin commented May 25, 2018

This happens because a particular char is checked here, not a keycode https://github.com/Day8/re-frame-10x/blob/master/src/day8/re_frame_10x.cljs#L173

@danielcompton
Copy link
Contributor

A PR would be welcome for this to switch to the keycode. We've had quite a few issues with this toggling hotkey, so we may need to take a different approach in the future, but for now, happy to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants