Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add re-frame.subs, re-frame.fx, and re-frame.cofx to :require #164

Merged
merged 1 commit into from Feb 27, 2018

Conversation

kennyjwilli
Copy link

day8.re-frame-10x.view.parts does not require re-frame.subs, re-frame.fx, and re-frame.cofx, all of which it uses. This causes shadow-cljs to throw warnings on initial compile:

11:41:42 CLJS | ------ WARNING #1 --------------------------------------------------------------
11:41:42 CLJS |  File: day8/re_frame_10x/view/parts.cljs:26:28
11:41:42 CLJS | --------------------------------------------------------------------------------
11:41:42 CLJS |   23 |    :children [[:h1 "Events"]
11:41:42 CLJS |   24 |               (render-registered re-frame.events/kind)
11:41:42 CLJS |   25 |               [:h1 "Subscriptions"]
11:41:42 CLJS |   26 |               (render-subs re-frame.subs/kind)
11:41:42 CLJS | ----------------------------------^---------------------------------------------
11:41:42 CLJS |  Use of undeclared Var re-frame.subs/kind
11:41:42 CLJS | --------------------------------------------------------------------------------
11:41:42 CLJS |   27 |               [:h1 "FX"]
11:41:42 CLJS |   28 |               (render-registered re-frame.fx/kind)
11:41:42 CLJS |   29 |               [:h1 "co-fx"]
11:41:42 CLJS |   30 |               (render-registered re-frame.cofx/kind)
11:41:42 CLJS | --------------------------------------------------------------------------------
11:41:42 CLJS | 
11:41:42 CLJS | ------ WARNING #2 --------------------------------------------------------------
11:41:42 CLJS |  File: day8/re_frame_10x/view/parts.cljs:28:34
11:41:42 CLJS | --------------------------------------------------------------------------------
11:41:42 CLJS |   25 |               [:h1 "Subscriptions"]
11:41:42 CLJS |   26 |               (render-subs re-frame.subs/kind)
11:41:42 CLJS |   27 |               [:h1 "FX"]
11:41:42 CLJS |   28 |               (render-registered re-frame.fx/kind)
11:41:42 CLJS | ----------------------------------------^---------------------------------------
11:41:42 CLJS |  Use of undeclared Var re-frame.fx/kind
11:41:42 CLJS | --------------------------------------------------------------------------------
11:41:42 CLJS |   29 |               [:h1 "co-fx"]
11:41:42 CLJS |   30 |               (render-registered re-frame.cofx/kind)
11:41:42 CLJS |   31 |               ]])
11:41:42 CLJS | --------------------------------------------------------------------------------
11:41:42 CLJS | 
11:41:42 CLJS | ------ WARNING #3 --------------------------------------------------------------
11:41:42 CLJS |  File: day8/re_frame_10x/view/parts.cljs:30:34
11:41:42 CLJS | --------------------------------------------------------------------------------
11:41:42 CLJS |   27 |               [:h1 "FX"]
11:41:42 CLJS |   28 |               (render-registered re-frame.fx/kind)
11:41:42 CLJS |   29 |               [:h1 "co-fx"]
11:41:42 CLJS |   30 |               (render-registered re-frame.cofx/kind)
11:41:42 CLJS | ----------------------------------------^---------------------------------------
11:41:42 CLJS |  Use of undeclared Var re-frame.cofx/kind
11:41:42 CLJS | --------------------------------------------------------------------------------
11:41:42 CLJS |   31 |               ]])
11:41:42 CLJS | --------------------------------------------------------------------------------

Requiring these namespaces will fix this issue.

@danielcompton danielcompton merged commit 7e863d3 into day8:master Feb 27, 2018
@danielcompton
Copy link
Contributor

Sorry about that, merged now! I saw your post on #shadow-cljs and went to fix it quickly, before I saw you'd made the PR.

@danielcompton
Copy link
Contributor

Fixed in 7e863d3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants