Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify the state machine #134

Merged
merged 5 commits into from
Dec 6, 2015
Merged

simplify the state machine #134

merged 5 commits into from
Dec 6, 2015

Commits on Nov 7, 2015

  1. fix a couple of comment typos

    @scgilardi
    scgilardi committed Nov 7, 2015
    Configuration menu
    Copy the full SHA
    38120c4 View commit details
    Browse the repository at this point in the history

  2. simplify names: pause, resume, regularize run-queue 

    - pause-run -> pause
- begin-resume -> resume
  - no longer a multi-step process
- begin-run -> run-queue
  - so all action function names match their keywords
    @scgilardi
    scgilardi committed Nov 7, 2015
    Configuration menu
    Copy the full SHA
    bde0708 View commit details
    Browse the repository at this point in the history

  3. reorder to be the same as the order in the prototype

    @scgilardi
    scgilardi committed Nov 7, 2015
    Configuration menu
    Copy the full SHA
    fc9fa49 View commit details
    Browse the repository at this point in the history

  4. direct call to -run-queue from resume 

    - this now happens in the :running state
  - just like a run-queue, but with an unconditional handling of the
    first item on the queue
- no need to trigger here
    @scgilardi
    scgilardi committed Nov 7, 2015
    Configuration menu
    Copy the full SHA
    4a3d951 View commit details
    Browse the repository at this point in the history

  5. simplify state handling around resume

    @scgilardi
    scgilardi committed Nov 7, 2015
    Configuration menu
    Copy the full SHA
    e77fc53 View commit details
    Browse the repository at this point in the history