Skip to content

Commit

Permalink
fix: update prop types
Browse files Browse the repository at this point in the history
  • Loading branch information
daybrush committed Mar 31, 2023
1 parent 1b7d5ac commit fd622b0
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 32 deletions.
2 changes: 1 addition & 1 deletion packages/infinite-viewer/test/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ <h2 data-moveable>Infinite Viewer</h2>
});

requestAnimationFrame(() => {
const left = (viewer.getViewportWidth() - viewer.getContainerWidth() / viewer.getZoomX()) / 2
const left = (viewer.getViewportWidth() - viewer.getContainerWidth() / viewer.getZoomX()) / 2;
viewer.scrollTo(left, 0, {
duration: 1000,
});
Expand Down
6 changes: 3 additions & 3 deletions packages/lit-infinite-viewer/src/LitInfiniteViewer.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { LitElement, html, customElement, property } from "lit-element";
import VanillaInfiniteViewer, {
InfiniteViewerProperties,
InfiniteViewerOptions,
EVENTS, PROPERTIES, InfiniteViewerMethods, METHODS, OPTIONS
} from "infinite-viewer";
import { Properties, withMethods, MethodInterface } from "framework-utils";
Expand All @@ -18,7 +18,7 @@ export class LitInfiniteViewer extends LitElement {
})
private infiniteViewer!: VanillaInfiniteViewer;
public firstUpdated() {
const options: Partial<InfiniteViewerProperties> = {};
const options: Partial<InfiniteViewerOptions> = {};

OPTIONS.forEach(name => {
if (typeof this[name] !== "undefined") {
Expand Down Expand Up @@ -74,7 +74,7 @@ export class LitInfiniteViewer extends LitElement {
this.infiniteViewer.destroy();
}
}
export interface LitInfiniteViewer extends InfiniteViewerProperties,
export interface LitInfiniteViewer extends InfiniteViewerOptions,
MethodInterface<InfiniteViewerMethods, VanillaInfiniteViewer, LitInfiniteViewer, {
"click": "clickViewer",
"scrollTo": "scrollToViewer",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { InfiniteViewerEvents, InfiniteViewerProperties } from "infinite-viewer";
import { InfiniteViewerEvents, InfiniteViewerOptions } from "infinite-viewer";

export interface InfiniteViewerEventNames {
onScroll: "scroll";
Expand All @@ -12,6 +12,7 @@ export interface InfiniteViewerEventNames {
export type InfiniteViewerEventProps = {
[key in keyof InfiniteViewerEventNames]: (e: InfiniteViewerEvents[InfiniteViewerEventNames[key]]) => any;
};
export type InfiniteViewerProps = InfiniteViewerProperties & InfiniteViewerEventProps & {
export type InfiniteViewerProps = InfiniteViewerOptions & InfiniteViewerEventProps & {
className?: string;
[key: string]: any;
};
Original file line number Diff line number Diff line change
@@ -1,28 +1,15 @@
import VanillaInfiniteViewer, { InfiniteViewerMethods } from "infinite-viewer";
import { SvelteComponentDev } from "svelte/internal";
import VanillaInfiniteViewer, {
InfiniteViewerOptions,
InfiniteViewerMethods,
} from "infinite-viewer";
import { MethodInterface } from "framework-utils";


interface ComponentOptions {
target: HTMLElement;
anchor?: HTMLElement | null;
props?: {};
hydrate?: boolean;
intro?: boolean;
export default class InfiniteViewerComponent<T={}> extends SvelteComponentDev {
$$prop_def: InfiniteViewerOptions & T;
getInstance(): VanillaInfiniteViewer;
}

interface InfiniteViewerComponent extends MethodInterface<InfiniteViewerMethods, VanillaInfiniteViewer, InfiniteViewerComponent> {
new(options: ComponentOptions): any;
// client-side methods
$set(props: {}): void;
$on(event: string, callback: (event: CustomEvent) => void): void;
$destroy(): void;
// server-side methods
render(props?: {}): {
html: string;
css: { code: string; map: string | null };
head?: string;
};
export default interface InfiniteViewerComponent extends MethodInterface<InfiniteViewerMethods, VanillaInfiniteViewer, InfiniteViewerComponent> {
}

export default InfiniteViewerComponent;
export * from "infinite-viewer";
4 changes: 2 additions & 2 deletions packages/vue-infinite-viewer/src/InfiniteViewer.vue.d.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { MethodInterface } from "framework-utils";
import VanillaInfiniteViewer, { InfiniteViewerProperties, InfiniteViewerMethods } from "infinite-viewer";
import VanillaInfiniteViewer, { InfiniteViewerOptions, InfiniteViewerMethods } from "infinite-viewer";

interface InfiniteViewerInterface
extends InfiniteViewerProperties,
extends InfiniteViewerOptions,
MethodInterface<
InfiniteViewerMethods,
VanillaInfiniteViewer,
Expand Down
4 changes: 2 additions & 2 deletions packages/vue3-infinite-viewer/src/InfiniteViewer.vue.d.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { MethodInterface } from "framework-utils";
import VanillaInfiniteViewer, { InfiniteViewerProperties, InfiniteViewerMethods } from "infinite-viewer";
import VanillaInfiniteViewer, { InfiniteViewerOptions, InfiniteViewerMethods } from "infinite-viewer";

interface InfiniteViewerInterface
extends InfiniteViewerProperties,
extends InfiniteViewerOptions,
MethodInterface<
InfiniteViewerMethods,
VanillaInfiniteViewer,
Expand Down

0 comments on commit fd622b0

Please sign in to comment.