Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect transform calculation when setFixedDirection set to [0, 0] #624

Closed
seahindeniz opened this issue Mar 15, 2022 · 12 comments
Closed
Labels
bug Something isn't working complete
Milestone

Comments

@seahindeniz
Copy link

Environments

Description

When I use setFixedDirection([0, 0]) mouse position is not calculated correctly or as it should.
I have recorded my screen and tried to show how to reproduce this issue and how I expect it to work: https://www.loom.com/share/2d92fa6230774874a64bf441dbb30bde

@daybrush daybrush added the bug Something isn't working label Apr 2, 2022
@daybrush daybrush added this to the 0.29.0 milestone Apr 2, 2022
daybrush added a commit that referenced this issue Apr 6, 2022
@daybrush
Copy link
Owner

@seahindeniz

  • moveable 0.29.1
  • react-moveable 0.32.1
  • preact-moveable 0.31.1
  • ngx-moveable 0.25.1
  • svelte-moveable 0.19.1
  • lit-moveable 0.6.1
  • vue-moveable 2.0.0-beta.8
  • vue3-moveable 0.4.1

moveable's new version is released.

try it again.

@seahindeniz
Copy link
Author

Hey @daybrush! Thanks for the new release. One small issue though. Seems like the corner handle, still doesn't follow the mouse cursor.

Here:

4f1848d3-c876-4316-821d-8bb13474c0c2.mp4

From what I can tell, and logically speaking, the handle should also follow the mouse cursor as like the non-setFixedDirection version of it.

Like this:

bcfcc108-ce57-47c5-990d-146fd46e4b7c

daybrush added a commit that referenced this issue Apr 18, 2022
@daybrush
Copy link
Owner

@seahindeniz

  • moveable 0.29.2
  • react-moveable 0.32.2
  • preact-moveable 0.31.2
  • ngx-moveable 0.25.2
  • svelte-moveable 0.19.2
  • lit-moveable 0.6.2
  • vue-moveable 2.0.0-beta.9
  • vue3-moveable 0.4.2

moveable's new version is released. Try it again.

@seahindeniz
Copy link
Author

@daybrush
Copy link
Owner

@seahindeniz

  • moveable 0.29.3
  • react-moveable 0.32.3
  • preact-moveable 0.31.3
  • ngx-moveable 0.25.3
  • svelte-moveable 0.19.3
  • lit-moveable 0.6.3
  • vue-moveable 2.0.0-beta.10
  • vue3-moveable 0.4.3

moveable's new version is released. Check it again.

@seahindeniz
Copy link
Author

Hey @daybrush, it works as expected and perfectly ✨ Kudos to you!

@seahindeniz
Copy link
Author

Hey @daybrush
I've found a case that the fixed issues still persist.
Here:

Screen.Recording.2022-04-27.at.13-Low-64k.mov

https://codesandbox.io/s/moveable-resize-fixed-direction-issue-0-29-4-q3hyri

@daybrush
Copy link
Owner

daybrush commented May 7, 2022

@seahindeniz

Test 0.29.8 version. It works, but there is another minor problem. I'll check.

@daybrush daybrush modified the milestones: 0.29.0, 0.29.9 May 7, 2022
daybrush added a commit that referenced this issue May 8, 2022
@daybrush
Copy link
Owner

daybrush commented Jun 7, 2022

@seahindeniz

0.29.9 is released. Check it again.

@seahindeniz
Copy link
Author

Hi @daybrush, seems like the last issue still persist
https://codesandbox.io/s/moveable-resize-fixed-direction-issue-0-29-9-gyj9gq

Kapture.2022-06-08.at.22.21.57.mp4

@daybrush
Copy link
Owner

daybrush commented Jun 9, 2022

@seahindeniz

Set target's style

    position: absolute;
    top: 0;
    left: 0;

@seahindeniz
Copy link
Author

It's working quite nice 🙏🏻 Thank you, @daybrush

https://codesandbox.io/s/moveable-resize-fixed-direction-issue-0-33-0-success-wsh1d8

@daybrush daybrush closed this as completed Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working complete
Projects
None yet
Development

No branches or pull requests

2 participants