Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: new moveable package (0.31.0) doesn't contain the /dist folder... #700

Closed
ulissepress opened this issue Jul 17, 2022 · 12 comments
Closed
Labels
bug Something isn't working complete

Comments

@ulissepress
Copy link

See Issue #690 for more details.

@daybrush daybrush added bug Something isn't working complete and removed complete labels Jul 17, 2022
@ulissepress
Copy link
Author

I did... and same problem. Even installing vue3-moveable 0.6.1 (that requires moveble 0.31.1) I am getting same error, as I see that in the node_modules/moveable folder the '/dist' directory is still missing...

@daybrush
Copy link
Owner

@ulissepress

sorry. I do not know what changes in npm, but there was a phenomenon in which dist and declaration were omitted, and now it has been fixed.

Test vue3-moveable@0.6.2

@ulissepress
Copy link
Author

ulissepress commented Jul 17, 2022

...now I have a different problem, but similar context:

✘ [ERROR] [plugin vite:dep-scan] Failed to resolve entry for package "vue3-moveable". 
The package may have incorrect main/module/exports specified in its package.json:
Failed to resolve entry for package "vue3-moveable". 
The package may have incorrect main/module/exports specified in its package.json.

If I look at the vue3-moveable packages.json (0.6.2):

    "name": "vue3-moveable",
    "version": "0.6.2",
    "description": "A Vue 3 Component that create Moveable, Draggable, Resizable, Scalable, Rotatable, Warpable, Pinchable, Groupable.",
    "types": "declaration/index.d.ts",
    "main": "dist/moveable.cjs.js",
    "module": "dist/moveable.esm.js",

but in the /dist folder I see only the .cjs.js file, while the moveable.esm.js file is missing...
image

PS: to avoid any context problem I am always deleting the node_modules folder and then run a npm install command

@daybrush
Copy link
Owner

@ulissepress

I checked the dist of all modules.

The problem only occurred with vue-moveable and vue3-moveable.

Version 0.6.3 was released. test it

@ulissepress
Copy link
Author

ulissepress commented Jul 17, 2022

Thank you for the new release. The compilation with Vite is now ok... but the project I'm working on (that was ok before upgrade) now is throwing this runtime error:

image

If I revert back to the previous version of vue3-moveable everything is fine... any idea where the problem can be ?

@ulissepress
Copy link
Author

Debugging a bit... the issue is in the vue-guides package. If I remove it from my app, everything is working again... I am using vue-guides 0.17.2

@daybrush
Copy link
Owner

@ulissepress

Use vue3-guides instead of vue-guides

@ulissepress
Copy link
Author

wow I did not realized that I was using vue-guides instead of vue3-guides. In any case:

  1. If I use vue-guide 0.17.1 everying is fine
  2. if I install vue3-guides 0.1.0 I am getting Vite compilation error as, again, the /dist folder is not there...:

image

image

seems there is a problem with your build scripts and/or npm publish?!?

@daybrush
Copy link
Owner

@ulissepress

it was the same issue. test 0.1.1 version

@ulissepress
Copy link
Author

A small suggestion: if you look at the page https://github.com/daybrush/guides you see that there is no 'packages' section (that instead is there in the other packages like moveable). Thanks to this section I knew about vue3-moveble (and not aware that also vue3-guides was existing....)

@daybrush
Copy link
Owner

@ulissepress

Although vue3 only has labels, I will add a package section later.

@ulissepress
Copy link
Author

ulissepress commented Jul 17, 2022

Thank you, with vue3-guides 0.1.1 now everything is working again!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working complete
Projects
None yet
Development

No branches or pull requests

2 participants