Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor style doesn't change when edgeDraggable: true #703

Closed
pclancysc opened this issue Jul 21, 2022 · 3 comments
Closed

Cursor style doesn't change when edgeDraggable: true #703

pclancysc opened this issue Jul 21, 2022 · 3 comments

Comments

@pclancysc
Copy link

Environments

  • Framework name: ngx-moveable
  • Framework version: 0.28.2
  • Moveable Component version:
  • Testable Address(optional):

Description

When resize is enabled on east and west edges and edge drag is also enabled the cursor doesn't change to a "drag/move" icon when the pointer is on an edge that will drag.

Sinced the edge is a div that only has the classes moveable-line and moveable-direction I can't find a way to show the appropiate cursor. If the n, e, s w edge could be detected on hover the class names could be modified to indicate which edge the pointer is over and then apply the appropiate cursor style.

e.g.

Pointer over top edge: moveable-line moveable-direction.moveable-n
Pointer over left edge: moveable-line moveable-direction.moveable-w

Is there any other solution that doesn't involve adding these classes in code?

@daybrush
Copy link
Owner

@pclancysc

  • lit-moveable 0.9.0
  • moveable 0.32.0
  • preact-moveable 0.34.0
  • react-compat-moveable 0.20.0
  • react-moveable 0.35.0
  • svelte-moveable 0.24.0
  • vue-moveable 2.0.0-beta.26
  • vue3-moveable 0.7.0
  • ngx-moveable 0.29.0

moveable's new version is released. When edgeDraggable is used, the cursor changes to move.

@pclancysc
Copy link
Author

@daybrush Thanks for the speedy fix. One thing that may or may not be an issue is that when I upgraded ngx-moveable I had errors regarding React types. I had to install @types/react to compile.

@daybrush
Copy link
Owner

@pclancysc

I'll check. Most likely I set the type wrong.

daybrush added a commit that referenced this issue Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants