Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drag undefined on Rotate Group events #710

Open
mamsoudi opened this issue Aug 1, 2022 · 3 comments
Open

drag undefined on Rotate Group events #710

mamsoudi opened this issue Aug 1, 2022 · 3 comments
Labels
bug Something isn't working complete
Milestone

Comments

@mamsoudi
Copy link

mamsoudi commented Aug 1, 2022

Environments

Description

What happens essentially after v0.33.0 is that onRotateGroup the drag object get's undefined. The link above is directly taken from the Storybook and opened in Sandbox, if we downgrade to v0.32.0 we see that's not a problem. On v0.33.0 however, drag is undefined. Not sure if the API has changed or not.

@mamsoudi
Copy link
Author

mamsoudi commented Aug 1, 2022

Also noticed that since v0.31.0 there's an unexpected change in how group rotation works. Again it's testable in the Sandbox going to v0.30.0 we can see that groups rotate normally (similar to the website). Notice how the behaviour of the rotation handler changes when I switch to v0.31.0:
bug

@daybrush daybrush added the bug Something isn't working label Aug 1, 2022
@daybrush daybrush added this to the 0.34.0 milestone Aug 1, 2022
daybrush added a commit that referenced this issue Aug 1, 2022
@daybrush
Copy link
Owner

daybrush commented Aug 1, 2022

@mamsoudi

  • lit-moveable 0.11.2
  • moveable 0.34.2
  • preact-moveable 0.36.2
  • react-compat-moveable 0.22.2
  • react-moveable 0.37.2
  • svelte-moveable 0.26.2
  • vue-moveable 2.0.0-beta.30
  • vue3-moveable 0.9.2
  • ngx-moveable 0.31.2

moveable's new version is released. Check it again.

@mamsoudi
Copy link
Author

mamsoudi commented Aug 1, 2022

Thanks a huge bunch! @daybrush Will give it a try ASAP!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working complete
Projects
None yet
Development

No branches or pull requests

2 participants