Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive on encryption check for Fusion Drives #3

Closed
dayglojesus opened this issue Dec 5, 2013 · 5 comments
Closed

False positive on encryption check for Fusion Drives #3

dayglojesus opened this issue Dec 5, 2013 · 5 comments

Comments

@dayglojesus
Copy link
Owner

There is anecdotal evidence that this app will refuse to run on Fusion drives because it falsely detects the "drive" is already encrypted.

@rtrouton
Copy link

rtrouton commented Dec 6, 2013

How are you doing the detection of an encrypted drive? Are you using "fdesetup status" or some other means?

@dayglojesus
Copy link
Owner Author

Not fdesetup. It uses some CoreFoundation functions which worked in all my testing until today.

https://github.com/dayglojesus/filevaultsetup/blob/master/FileVault%20Setup/FVSAppDelegate.m#L93

I don't suppose you have any unencrypted fusion drives you can try launching this app on?

@rtrouton
Copy link

rtrouton commented Dec 6, 2013

I don't, but it should be possible to create one in a VMware Fusion VM using these instructions:

http://www.macworld.com/article/2014011/how-to-make-your-own-fusion-drive.html

I tested my FileVault 2 check scripts against a homebrew Fusion drive inside an OS X VM running in Fusion. It was a good simulator and gave me the same results as an actual Apple-provided Fusion drive.

@dayglojesus
Copy link
Owner Author

That sounds promising. Unfortunately, it will be at least a week before I can test and patch this. I will see if any of the team can give it a whirl.

In the meantime, if you have time to test it, please let me know how it goes.

Thanks, Rich!

dayglojesus pushed a commit that referenced this issue Jan 7, 2014
- null isEncrypted var was returning false positives on CoreStorage
volumes
dayglojesus pushed a commit that referenced this issue Jan 7, 2014
@dayglojesus
Copy link
Owner Author

Thanks for the suggestion @rtrouton. This issue should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants