Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added all flag #118

Merged
merged 4 commits into from
Mar 11, 2024
Merged

feat: added all flag #118

merged 4 commits into from
Mar 11, 2024

Conversation

guptadeepak8
Copy link
Contributor

@guptadeepak8 guptadeepak8 commented Mar 7, 2024

Pull Request Title

Added -all flag for start, stop and delete cmd

Type of Change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have performed a self-review of my own code

Related Issue(s)

This PR addresses issue #116

/claim #116

Copy link
Member

@Tpuljak Tpuljak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small comments. Other than that, looks very good.

pkg/cmd/workspace/delete.go Outdated Show resolved Hide resolved
pkg/cmd/workspace/delete.go Outdated Show resolved Hide resolved
pkg/cmd/workspace/start.go Outdated Show resolved Hide resolved
pkg/cmd/workspace/stop.go Outdated Show resolved Hide resolved
@Tpuljak
Copy link
Member

Tpuljak commented Mar 7, 2024

@guptadeepak8 thanks for the PR.

A couple of notes, other than those in the review.

Please start an Algora attempt it #116 so we can assign the bounty to you. Generally, it would be best that you wait to be assigned to the issue before opening the PR.

Additionally, can you please do the following:

  1. Rebase the commit to fix the message. A space is missing in feat: ...
  2. Please edit the PR description. You need to remove the extra space when adding a checkmark (like this [x])

@Tpuljak
Copy link
Member

Tpuljak commented Mar 8, 2024

Hi @guptadeepak8,

In addition to the changes above, please add yourself to our CONTRIBUTORS.md file with your name and Github username.

You can find an example PR here and here.

Also, please read through our contributing guidelines to familiarize yourself with our license rules.

@guptadeepak8 guptadeepak8 changed the title feat:added all flag feat: added all flag Mar 8, 2024
pkg/cmd/workspace/delete.go Outdated Show resolved Hide resolved
@guptadeepak8
Copy link
Contributor Author

@Tpuljak made changes

pkg/cmd/workspace/stop.go Outdated Show resolved Hide resolved
@Tpuljak
Copy link
Member

Tpuljak commented Mar 9, 2024

Please start an Algora attempt it #116 so we can assign the bounty to you. Generally, it would be best that you wait to be assigned to the issue before opening the PR.

@guptadeepak8, just a reminder to submit an attempt at #116 so I can assign you

Copy link
Member

@Tpuljak Tpuljak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guptadeepak8 nice job! Everything is in order.

@Tpuljak Tpuljak merged commit 96ffe08 into daytonaio:main Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants