-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added all flag #118
feat: added all flag #118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small comments. Other than that, looks very good.
@guptadeepak8 thanks for the PR. A couple of notes, other than those in the review. Please start an Algora attempt it #116 so we can assign the bounty to you. Generally, it would be best that you wait to be assigned to the issue before opening the PR. Additionally, can you please do the following:
|
Hi @guptadeepak8, In addition to the changes above, please add yourself to our CONTRIBUTORS.md file with your name and Github username. You can find an example PR here and here. Also, please read through our contributing guidelines to familiarize yourself with our license rules. |
@Tpuljak made changes |
@guptadeepak8, just a reminder to submit an attempt at #116 so I can assign you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guptadeepak8 nice job! Everything is in order.
Pull Request Title
Added -all flag for start, stop and delete cmd
Type of Change
Checklist
Related Issue(s)
This PR addresses issue #116
/claim #116