Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close file in the ChmodX func #414

Merged
merged 1 commit into from
Apr 20, 2024
Merged

fix: close file in the ChmodX func #414

merged 1 commit into from
Apr 20, 2024

Conversation

testwill
Copy link
Contributor

@testwill testwill commented Apr 19, 2024 •
edited by Tpuljak

Description

Close file in the ChmodX func

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@testwill testwill requested a review from a team as a code owner April 19, 2024 07:38
@testwill
fix: close file in the ChmodX func
2d1ae32 
Signed-off-by: guoguangwu <guoguangwug@gmail.com>
Tpuljak
Tpuljak approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@Tpuljak Tpuljak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@Tpuljak Tpuljak merged commit 011b483 into daytonaio:main Apr 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vedranjukic vedranjukic vedranjukic approved these changes

@Tpuljak Tpuljak Tpuljak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@testwill @vedranjukic @Tpuljak