Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: required project name #426

Merged
merged 1 commit into from
Apr 24, 2024
Merged

fix: required project name #426

merged 1 commit into from
Apr 24, 2024

Conversation

idagelic
Copy link
Member

@idagelic idagelic commented Apr 23, 2024

Make project name required in backend

Description

Makes project name required and non-empty when creating a workspace.
This is done by implementing an api level validator which will be used in the future

After consideration, ID is unnecessary as a part of the project request DTO so it has been removed.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@idagelic idagelic requested review from a team as code owners April 23, 2024 10:15
Signed-off-by: Ivan Dagelic <dagelic.ivan@gmail.com>
@idagelic idagelic changed the title fix: required project id name fix: required project name Apr 24, 2024
@idagelic idagelic merged commit 71e4d3b into main Apr 24, 2024
5 checks passed
@idagelic idagelic deleted the required-project-id-name branch April 24, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants