Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: advanced project configuration in cli #429

Merged
merged 6 commits into from
Apr 26, 2024
Merged

feat: advanced project configuration in cli #429

merged 6 commits into from
Apr 26, 2024

Conversation

idagelic
Copy link
Member

@idagelic idagelic commented Apr 24, 2024

Project configuration

Description

Adds an additional project configuration screen

  • for single project workspaces it can be opened by pressing "f10" during workspace name form
  • for multi project workspaces it can be opened by pressing "f10" during summary screen

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Related Issue(s)

This PR closes issue #416

Screenshots

Single project:

image

image

Multi project:
image

image

image

@idagelic idagelic force-pushed the advanced-create branch 4 times, most recently from c1b60e2 to 851b1ba Compare April 25, 2024 09:12
@idagelic idagelic changed the title Advanced create feat: advanced project configuration in cli Apr 25, 2024
@idagelic idagelic marked this pull request as ready for review April 25, 2024 09:14
@idagelic idagelic requested a review from a team as a code owner April 25, 2024 09:14
pkg/cmd/workspace/util/creation_data.go Outdated Show resolved Hide resolved
pkg/cmd/workspace/util/creation_data.go Outdated Show resolved Hide resolved
pkg/views/workspace/create/configuration.go Outdated Show resolved Hide resolved
pkg/views/workspace/create/workspacedata.go Outdated Show resolved Hide resolved
pkg/views/workspace/create/workspacedata.go Outdated Show resolved Hide resolved
@idagelic idagelic force-pushed the advanced-create branch 3 times, most recently from 8910c03 to 89ed888 Compare April 25, 2024 11:24
@Tpuljak
Copy link
Member

Tpuljak commented Apr 25, 2024

Screen.Recording.2024-04-25.at.14.38.12.mov

Seems that the advanced config for multi-project doesn't work as expected. It always aborts for me.
(EDIT: Might have something to do with selecting ABORT before going to the advanced config screen)

Also, 2 more comments:

  1. Can we have F10 return back to the "Good to go" screen while on the project configuration list?
  2. The Done configuring projects? screen seems unnecessary to me. I would prefer just being returned to the list and then returning to "Good to go" with F10. Feels to me that the experience would be more consistent.

Signed-off-by: Ivan Dagelic <dagelic.ivan@gmail.com>
Signed-off-by: Ivan Dagelic <dagelic.ivan@gmail.com>
Signed-off-by: Ivan Dagelic <dagelic.ivan@gmail.com>
Signed-off-by: Ivan Dagelic <dagelic.ivan@gmail.com>
@idagelic
Copy link
Member Author

Snimka.2024-04-25.181800.mp4

Signed-off-by: Ivan Dagelic <dagelic.ivan@gmail.com>
Signed-off-by: Ivan Dagelic <dagelic.ivan@gmail.com>
@idagelic idagelic merged commit 2a6e25f into main Apr 26, 2024
5 checks passed
@idagelic idagelic deleted the advanced-create branch April 26, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants