Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement the docker client package #433

Merged
merged 1 commit into from
Apr 26, 2024
Merged

feat: implement the docker client package #433

merged 1 commit into from
Apr 26, 2024

Conversation

Tpuljak
Copy link
Member

@Tpuljak Tpuljak commented Apr 25, 2024

Docker Client Package

Description

This PR contributes the docker pkg that holds the DockerClient interface and implementation. The DockerClient is meant to be reused in all "Docker-based" providers (e.g. Docker, Digital Ocean, etc.).
This will make the code much more maintainable in those providers.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@Tpuljak Tpuljak requested a review from a team as a code owner April 25, 2024 14:33
The package will be reused in all Docker-based providers

Signed-off-by: Toma Puljak <toma.puljak@hotmail.com>
@Tpuljak Tpuljak merged commit 7338fb4 into main Apr 26, 2024
5 checks passed
@Tpuljak Tpuljak deleted the docker-client branch April 26, 2024 09:22
@Tpuljak Tpuljak mentioned this pull request Apr 26, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants