Component refactor #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TehShrike
commented
May 28, 2017
TehShrike
commented
- Split the two tables into different templates
- represent "shown" in a separate data structure
- rename "Channels" to "Main"
- in ChannelList, moved the provider data from the template to a data structure
- made a Checkbox component because of this bug: Compiler error "Cannot read property 'name' of null" with two-way-binding + brackets sveltejs/svelte#602
- changed provider-channels to export an array instead of an object with a single array property
- added svelte as an explicit dependency for version pinning
- in ChannelList, moved the provider data from the template to a data structure - made a Checkbox component because of this bug: sveltejs/svelte#602 - changed provider-channels to export an array instead of an object with a single array property - added svelte as an explicit dependency for version pinning
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.