Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pydfs init #3

Merged
merged 5 commits into from
Jul 2, 2022
Merged

pydfs init #3

merged 5 commits into from
Jul 2, 2022

Conversation

dayyass
Copy link
Owner

@dayyass dayyass commented Jul 1, 2022

No description provided.

@dayyass dayyass added the enhancement New feature or request label Jul 1, 2022
@dayyass dayyass requested a review from epivoca July 1, 2022 19:32
@dayyass dayyass self-assigned this Jul 1, 2022
epivoca
epivoca reviewed Jul 2, 2022
View reviewed changes
pydfs/cmd_init.py

# TODO: maybe move it up
from pydfs.flask_init_master import app # noqa: E402

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Возможно стоит продумать логику, что master может быть создан только один? (на данном этапе разработки) Singleton?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Да, сделаем это в следующих релизах

@dayyass dayyass merged commit 3692fce into develop Jul 2, 2022
@dayyass dayyass deleted the pydfs_init branch July 2, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epivoca epivoca epivoca left review comments

Assignees

@dayyass dayyass

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dayyass @epivoca