-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-build manifest file #58
Comments
Yep this makes sense to me. I have considered auto building the manifest using attributes, and I have created a library here that can be used to programatically build a manifest and then save it to xml. So for me this definately makes sense as a feature for DnnPackager, i.e during the current packaging task it can:
One concern with this approach is that I don't like the idea that you would have to reference the assembly containing these attributes in your module / project, because that means you also have to deploy this additional assembly with your module - when it really is only needed at build time - it's now become a runtime dependency. As you can imagine, if you have one module installed using 1 version of this attributes assembly, and then you install another module using a slightly later version of that attributes assembly - there can only be one version of it in the bin folder, so something will break in that scenario. I think there are a couple of solutions to eliminate the runtime dependency on the attributes assembly:
Also the amount of attributes that you would need to represent the manifest could be quite a lot.. Would have to think very carefully about the attributes themselves and how to make them simple but effective! |
This is also very similar to how Xamarin projects work for Android applications so it should be kind of familiar for those developers.. You can manually edit the android application manifest, but you can also use attributes to suppliment the manifest data. |
Will close this as decided will want to go ahead with this. Read #60 for further info about how I see this working. |
Thanks @dazinator! |
@dazinator not sure if you have looked into this possibility or not, but thought I would at least log it for consideration. I ran across some work being done by XCESS here and thought it was a great idea. It would be nice to not have to manually maintain the manifest file. Your thoughts?
The text was updated successfully, but these errors were encountered: