-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Characters missing from list of allowable path characters #52
Comments
Yeah you are right - this needs sorting. Firstly the doc should say
Not just A-Z, a-z or Digit. Because it actually does The last character however !is categorised as unicode However taken into a wider context - I don't think this "allowed literal characters" limitation is really helping anything much and I think I should just remove it. Like you say the set of allowed characters will differ per platform and that's not something I want to get into really. This originally evolved because I wanted to identify if a character was a literal, and I thought if there was a small subset / array I could check in that pretty quickly. But actually the better approach seems to be parse for literals So here is what I think I should do:
The default behaviour will then just be that the character will be assumed to be a literal if it isn't parsed as any other token first - which is how |
Yep, treating anything that isn't a special character as a literal makes sense to me |
Thanks @cocowalla this will be releases in |
The readme says:
Maybe I'm misunderstanding this section, but on all of Windows, Linux and MacOS, lot's of other characters are valid in file system paths, such as:
{
}
[
]
(
)
+
;
%
?
*
Also, on Windows
:
is not valid.The text was updated successfully, but these errors were encountered: