Handle more than one single quote in string literals in a portable way #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per [1], [2] and [3], a single quotation mark `'` has to be replaced by `''` in a string literal. - [1]:http://pic.dhe.ibm.com/infocenter/idshelp/v117/index.jsp?topic=%2Fcom.ibm.gen_busug.doc%2Fc_fgl_sql_programming_080.htm - [2]:http://www.postgresql.org/docs/9.3/static/sql-syntax-lexical.html#SQL-SYNTAX-STRINGS - [3]:http://dev.mysql.com/doc/refman/5.0/en/string-literals.html
Make everything use the same method for escaping. It was couple of inline `.replace` calls before (in base and mysql drivers).
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
''(two single quotes) with'inside a string literal. Also handles more than one single quote (/'/vs./'/g).Makes everything use the
escapemethod fromdriver/baseinstead of inline.replace(…)calls in two places.If merged, renders PR #143 obsolete.
I'm not sure if duplicating "insert" tests just to include single quotes inside title is a good idea. Maybe I should've added them to existing "insert" tests?