Merge 45598df into 8a944c8

dbader · Apr 4, 2022 · f94caa5 · f94caa5
2 parents 8a944c8 + 45598df
commit f94caa5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/schedule/__init__.py b/schedule/__init__.py
@@ -481,7 +481,7 @@ def at(self, time_str):
         if not isinstance(time_str, str):
             raise TypeError("at() should be passed a string")
         if self.unit == "days" or self.start_day:
-            if not re.match(r"^([0-2]\d:)?[0-5]\d:[0-5]\d$", time_str):
+            if not re.match(r"^[0-2]\d:[0-5]\d(:[0-5]\d)?$", time_str):
                 raise ScheduleValueError(
                     "Invalid time format for a daily job (valid format is HH:MM(:SS)?)"
                 )

diff --git a/test_schedule.py b/test_schedule.py
@@ -225,6 +225,7 @@ def test_at_time(self):
         mock_job = make_mock_job()
         assert every().day.at("10:30").do(mock_job).next_run.hour == 10
         assert every().day.at("10:30").do(mock_job).next_run.minute == 30
+        assert every().day.at("20:59").do(mock_job).next_run.minute == 59
         assert every().day.at("10:30:50").do(mock_job).next_run.second == 50
 
         self.assertRaises(ScheduleValueError, every().day.at, "2:30:000001")
@@ -233,6 +234,7 @@ def test_at_time(self):
         self.assertRaises(ScheduleValueError, every().day.at, "2")
         self.assertRaises(ScheduleValueError, every().day.at, ":2")
         self.assertRaises(ScheduleValueError, every().day.at, " 2:30:00")
+        self.assertRaises(ScheduleValueError, every().day.at, "59:59")
         self.assertRaises(ScheduleValueError, every().do, lambda: 0)
         self.assertRaises(TypeError, every().day.at, 2)