Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add removeCombined flag to allow opting out of removing files during build #45

Closed
chrylis opened this issue Feb 16, 2015 · 5 comments
Closed

Comments

@chrylis
Copy link

chrylis commented Feb 16, 2015

After optimization, mimosa-require removes JavaScript files with modules that were rolled up. This appears to be part of the module itself and not r.js; the log lines are colorized, and I have removeCombined: false in my overrides. (Setting removeCombined: true causes r.js to remove them, and the debug message do not appear.)

I'm running Karma in a downstream build step (mimosa-karma isn't working for me), and I need to keep the module files for testing.

Since r.js has its own removeCombined option, I suggest not running the cleanup phase when the external r.js is used.

@dbashford
Copy link
Owner

I can't rely on r.js. If there are multiple single page apps (not modules) then r.js is invoked multiple times. If using r.js' removeCombined, then after the first run all the files would be nuked. And if those files are needed for the 2nd run...

@dbashford
Copy link
Owner

So, considering mimosa cannot use r.js, is the request here to be able to configure mimosa's removeCombine?

@chrylis
Copy link
Author

chrylis commented Feb 20, 2015

I believe so. Is this already an option? I dumped the config and didn't notice anything that looked applicable.

@dbashford
Copy link
Owner

Nope, would need to add that.

Sent from myMail for iOS

Friday, February 20, 2015, 5:08 AM -0500 from Christopher Smith notifications@github.com:
I believe so. Is this already an option? I dumped the config and didn't notice anything that looked applicable.

Reply to this email directly or view it on GitHub .

@dbashford dbashford changed the title Keeping optimized modules Add removeCombined flag to allow opting out of removing files during build Feb 25, 2015
@dbashford
Copy link
Owner

v3.1.5 and v2.3.5 contain a new flag. See the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants