-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add removeCombined flag to allow opting out of removing files during build #45
Comments
I can't rely on r.js. If there are multiple single page apps (not modules) then r.js is invoked multiple times. If using r.js' removeCombined, then after the first run all the files would be nuked. And if those files are needed for the 2nd run... |
So, considering mimosa cannot use r.js, is the request here to be able to configure mimosa's removeCombine? |
I believe so. Is this already an option? I dumped the config and didn't notice anything that looked applicable. |
Nope, would need to add that. Sent from myMail for iOS
|
|
After optimization,
mimosa-require
removes JavaScript files with modules that were rolled up. This appears to be part of the module itself and not r.js; the log lines are colorized, and I haveremoveCombined: false
in my overrides. (SettingremoveCombined: true
causes r.js to remove them, and the debug message do not appear.)I'm running Karma in a downstream build step (
mimosa-karma
isn't working for me), and I need to keep the module files for testing.Since r.js has its own
removeCombined
option, I suggest not running the cleanup phase when the external r.js is used.The text was updated successfully, but these errors were encountered: