V2 #308
Open
V2 #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the `ProjectConfig` class to be used as the main API. The new interface should be simpler to use and more intuitive as it behaves like a dict object.
The `ProjectConfig` class is no longer used, as is the `ConfigSchema` class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces some breaking changes:
ProjectConfighas been removed in favour of a newUserConfig. Objects of this class behave like a dict, removing the need for theget_optionmethod as config values can be retrieved as if they're dict values. Also removes the need for ato_dictmethod.pydanticis removed for the schema validation. For validation you now just need to supply a class that implements adictmethod, such as apydantic.BaseModel.