Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty FixedPositions #811

Merged
merged 6 commits into from
Mar 7, 2024
Merged

Fix empty FixedPositions #811

merged 6 commits into from
Mar 7, 2024

Conversation

Helveg
Copy link
Contributor

@Helveg Helveg commented Mar 7, 2024

Describe the work done

Improve get_node_name, and closes #802

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.84%. Comparing base (85ec28c) to head (75af8da).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #811      +/-   ##
==========================================
+ Coverage   83.81%   83.84%   +0.03%     
==========================================
  Files         106      106              
  Lines       13062    13100      +38     
==========================================
+ Hits        10948    10984      +36     
- Misses       2114     2116       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Helveg Helveg merged commit 4fc49a0 into main Mar 7, 2024
13 checks passed
@Helveg Helveg deleted the fix/issues/802 branch March 7, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FixedPositions with 0 positions errors
1 participant