Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gst calculation issue fixed #282

Merged
merged 7 commits into from
Apr 27, 2018
Merged

Conversation

FatemehMoghadam
Copy link
Contributor

@FatemehMoghadam FatemehMoghadam commented Apr 27, 2018

please check!


This change is Reviewable

@FatemehMoghadam FatemehMoghadam changed the title gst calculation isuue fixed gst calculation isue fixed Apr 27, 2018
@FatemehMoghadam FatemehMoghadam changed the title gst calculation isue fixed gst calculation issue fixed Apr 27, 2018
@scottp-dpaw
Copy link

ledger/payments/invoice/dashboard/views.py, line 29 at r1 (raw file):

    def get_context_data(self, **kwargs):
        ctx = super(InvoiceDetailView, self).get_context_data(**kwargs)
        ctx['bpay_allowed'] = settings.BPAY_ALLOWED

As discussed, need to add settings.INVOICE_UNPAID_WARNING to the context (just like with bpay_allowed) for the template to work


Comments from Reviewable

@coveralls
Copy link

coveralls commented Apr 27, 2018

Pull Request Test Coverage Report for Build 416

  • 2 of 15 (13.33%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.004%) to 43.39%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ledger/checkout/views.py 1 3 33.33%
ledger/payments/invoice/dashboard/views.py 0 2 0.0%
ledger/payments/utils.py 1 3 33.33%
parkstay/utils.py 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
ledger/checkout/views.py 1 17.62%
ledger/payments/invoice/dashboard/views.py 1 76.0%
parkstay/api.py 1 16.79%
Totals Coverage Status
Change from base Build 414: -0.004%
Covered Lines: 10279
Relevant Lines: 23690

💛 - Coveralls

@scottp-dpaw
Copy link

Reviewed 8 of 9 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@scottp-dpaw scottp-dpaw merged commit a00b957 into dbca-wa:master Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants