Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Details field for override reason - max vehicle per campsite #343

Merged
merged 3 commits into from
Jul 12, 2018

Conversation

FatemehMoghadam
Copy link
Contributor

@FatemehMoghadam FatemehMoghadam commented Jul 10, 2018

This change is Reviewable

@coveralls
Copy link

coveralls commented Jul 11, 2018

Pull Request Test Coverage Report for Build 485

  • 6 of 10 (60.0%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.002%) to 48.27%

Changes Missing Coverage Covered Lines Changed/Added Lines %
parkstay/api.py 1 3 33.33%
parkstay/utils.py 1 3 33.33%
Files with Coverage Reduction New Missed Lines %
parkstay/utils.py 1 50.33%
parkstay/models.py 1 54.34%
Totals Coverage Status
Change from base Build 482: 0.002%
Covered Lines: 11454
Relevant Lines: 23729

💛 - Coveralls

@scottp-dpaw
Copy link


parkstay/models.py, line 503 at r1 (raw file):

    min_people = models.SmallIntegerField(default=1)
    max_people = models.SmallIntegerField(default=12)
    max_vehicles = models.PositiveIntegerField(default=1)

Is the business happy with every existing campsite getting capped at 1 vehicle per booking by default?

Copy link

@scottp-dpaw scottp-dpaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @FatemehMoghadam)

Copy link

@scottp-dpaw scottp-dpaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@scottp-dpaw scottp-dpaw merged commit 8ee8a22 into dbca-wa:master Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants