Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Mooring Creation, updates and text changes #360

Merged
merged 6 commits into from
Aug 2, 2018

Conversation

xzzy
Copy link
Collaborator

@xzzy xzzy commented Aug 1, 2018

This change is Reviewable

@coveralls
Copy link

coveralls commented Aug 1, 2018

Pull Request Test Coverage Report for Build 499

  • 0 of 16 (0.0%) changed or added relevant lines in 3 files are covered.
  • 6 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.01%) to 39.745%

Changes Missing Coverage Covered Lines Changed/Added Lines %
mooring/serialisers.py 0 1 0.0%
mooring/settings.py 0 2 0.0%
mooring/api.py 0 13 0.0%
Files with Coverage Reduction New Missed Lines %
mooring/api.py 1 0.0%
ledger/payments/bpay/crn.py 1 55.22%
parkstay/models.py 1 54.34%
mooring/models.py 3 0.0%
Totals Coverage Status
Change from base Build 496: -0.01%
Covered Lines: 11454
Relevant Lines: 28819

💛 - Coveralls

@scottp-dpaw
Copy link


mooring/templates/mooring/index.html, line 44 at r1 (raw file):

                        </h4>
                        <p>
                            At the Department of Biodiversity and Attractions, we employ a password-less authentication system, meaning you never need to remember

Biodiversity, Conservation and Attractions

@scottp-dpaw
Copy link


mooring/context_processors.py, line 7 at r1 (raw file):

        'EXPLORE_PARKS_SEARCH': '{}/map'.format(settings.EXPLORE_PARKS_URL),
        'EXPLORE_PARKS_CONTACT': '{}/contact-us'.format(settings.EXPLORE_PARKS_URL),
        'EXPLORE_PARKS_CONSERVE': '{}/know/conserving-our-mooringgs'.format(settings.EXPLORE_PARKS_URL),

typo?

Copy link

@scottp-dpaw scottp-dpaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 10 files at r1.
Reviewable status: 8 of 10 files reviewed, 2 unresolved discussions (waiting on @xzzy)

Copy link

@scottp-dpaw scottp-dpaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r2.
Reviewable status: 13 of 14 files reviewed, 1 unresolved discussion (waiting on @xzzy)

Copy link

@scottp-dpaw scottp-dpaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@scottp-dpaw scottp-dpaw merged commit 98cb75d into dbca-wa:master Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants