Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add closure reason hove over and some minor changes #426

Merged
merged 7 commits into from
Oct 2, 2018

Conversation

FatemehMoghadam
Copy link
Contributor

@FatemehMoghadam FatemehMoghadam commented Sep 18, 2018

This change is Reviewable

Copy link

@scottp-dpaw scottp-dpaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 11 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@coveralls
Copy link

coveralls commented Oct 2, 2018

Pull Request Test Coverage Report for Build 569

  • 11 of 42 (26.19%) changed or added relevant lines in 4 files are covered.
  • 63 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.01%) to 39.227%

Changes Missing Coverage Covered Lines Changed/Added Lines %
parkstay/models.py 0 1 0.0%
parkstay/utils.py 5 8 62.5%
parkstay/api.py 0 27 0.0%
Files with Coverage Reduction New Missed Lines %
mooring/pdf.py 1 0.0%
ledger/payments/bpay/crn.py 1 55.22%
parkstay/api.py 1 18.44%
parkstay/models.py 1 54.38%
mooring/models.py 3 0.0%
parkstay/utils.py 4 49.76%
wildlifelicensing/apps/applications/views/conditions.py 22 82.67%
wildlifelicensing/apps/applications/views/view.py 30 42.86%
Totals Coverage Status
Change from base Build 542: -0.01%
Covered Lines: 11466
Relevant Lines: 29230

💛 - Coveralls

Copy link

@scottp-dpaw scottp-dpaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 11 files at r1, 2 of 4 files at r2, 9 of 9 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@scottp-dpaw scottp-dpaw merged commit beac55d into dbca-wa:master Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants