Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mooring Hire Bug Fixes #571

Merged
merged 16 commits into from
Apr 3, 2019
Merged

Mooring Hire Bug Fixes #571

merged 16 commits into from
Apr 3, 2019

Conversation

xzzy
Copy link
Collaborator

@xzzy xzzy commented Apr 2, 2019

This change is Reviewable

@coveralls
Copy link

coveralls commented Apr 2, 2019

Pull Request Test Coverage Report for Build 718

  • 57 of 138 (41.3%) changed or added relevant lines in 11 files are covered.
  • 276 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.6%) to 36.407%

Changes Missing Coverage Covered Lines Changed/Added Lines %
mooring/models.py 6 8 75.0%
mooring/reports.py 1 19 5.26%
mooring/views.py 1 30 3.33%
mooring/api.py 16 48 33.33%
Files with Coverage Reduction New Missed Lines %
mooring/reports.py 1 7.78%
ledger/payments/helpers.py 1 70.0%
parkstay/utils.py 1 48.58%
parkstay/emails.py 2 31.25%
ledger/payments/mixins.py 5 53.85%
ledger/payments/invoice/models.py 5 50.43%
parkstay/models.py 6 54.0%
mooring/views.py 11 22.58%
ledger/emails/emails.py 24 30.91%
ledger/payments/pdf.py 67 67.43%
Totals Coverage Status
Change from base Build 715: -0.6%
Covered Lines: 16924
Relevant Lines: 46486

💛 - Coveralls

Copy link
Contributor

@wilsonc86 wilsonc86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 33 of 33 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dbca-asi dbca-asi merged commit 856846a into dbca-wa:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants