Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Clarification of the completion key(s)? #73

Open
chocolateboy opened this issue Sep 1, 2019 · 1 comment
Open

[Documentation] Clarification of the completion key(s)? #73

chocolateboy opened this issue Sep 1, 2019 · 1 comment
Assignees
Labels
good first issue Good for newcomers

Comments

@chocolateboy
Copy link
Contributor

  • OS: Linux (Arch)
  • Python: 3.7.4
  • litecli: 1.1.0

This is a great tool (thanks!), but I was deterred from considering it by the references to completing with the "Right-arrow" key in the documentation (and UI). I'm used to completing with the standard GNU Readline Tab key (as in sqlite) and never use arrow keys for completion and don't use any tools which do by default (it's been a while since I last tried fish).

I then came here (after looking through the documentation on the site) to see if there's any way to override this setting but couldn't find one, so I looked elsewhere. (Actually, I tried to install it anyway to see if I could live with the weird key, but couldn't get it to install on Arch Linux.)

After getting frustrated with the default SQLite CLI again, I decided to give this another go and was delighted to find that tab-completion works as expected for keywords and identifiers, and that the arrow key is only used to complete history suggestions 👍.

Now that I know this, the documentation makes perfect sense, but it might be worth tweaking it slightly to avoid giving the impression that the right-arrow key is required for all completions.

@zzl0 zzl0 self-assigned this Oct 28, 2019
@zzl0
Copy link
Contributor

zzl0 commented Oct 28, 2019

@chocolateboy Thanks for your feedback. Yes, I agree with you, I will update the documentation and UI next week.

@amjith amjith added the good first issue Good for newcomers label Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants