mv authors

[meeuw]

Description

This patch is used by Fedora to get AUTHORS and SPONSORS in /usr/lib/pythonN/site-packages/mycli instead of /usr/lib/pythonN/site-packages.

Checklist

• I've added this contribution to the changelog.md.
• I've added my name to the AUTHORS file (or it's already there).

[tsroten]

Thanks for figuring this out. However, I think the best practice is to not include AUTHORS and SPONSORS in package_data at all.

They should be in the manifest file (and kept in the project root directory, not in the Python package itself).

[tsroten]

Oh wait, we need them for the credits when we load mycli. Hmm. Mycli really shouldn't load things outside of its package. But, I don't like the AUTHORS file not being in the project root directory.

Let's think through a better way to do this.

[tsroten]

Ok, what about data_files where we can control where they are installed? https://docs.python.org/3.4/distutils/setupscript.html#installing-additional-files

Maybe use the relative path mycli as the installation directory? Then we'll need to update the thanks_picker to look in the package itself.

Edit: Apparently, data_files is not reliable and shouldn't be used anymore.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@818f5cd). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #410   +/-   ##
=========================================
  Coverage          ?   72.67%           
=========================================
  Files             ?       29           
  Lines             ?     2543           
  Branches          ?        0           
=========================================
  Hits              ?     1848           
  Misses            ?      695           
  Partials          ?        0

Impacted Files	Coverage Δ
mycli/main.py	61.36% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 818f5cd...393ee31. Read the comment docs.

[meeuw]

I admit this is a bit lame, but is it acceptable to have AUTHORS.rst and SPONSORS.rst to redirect to the text files in our mycli directory?

[amjith]

Instead of adding a link inside the AUTHORS to mycli/AUTHORS why not just create a symlink?
We move AUTHORS and SPONSORS inside mycli folder and then symlink it to the outside folder?

[meeuw]

I don't know if it is important but last time I've used Windows/NTFS it didn't support symlinks.

And I don't know how github handles symlinks, I'm pushing a test commit...

[meeuw]

Yikes, github doesn't follow symlinks:
https://github.com/meeuw/dmtest

[tsroten]

@meeuw I removed the project_root variable. This pull request looks good to me. Anything holding it back now? Or are we good to merge?

[meeuw]

I've thought hard about alternatives but I cannot think of anything better than this, so -- good to merge!