sqlparse 0.3.0 is out and does not have any notable changes #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@VVelox Thanks for the PR. The tests are failing because sqlparse has changed the way the tokens are parsed. I have fixed this in pgcli. https://github.com/dbcli/pgcli/pull/1052/files Would you be open to porting the changes from pgcli to mycli using that PR? |
|
I fixed the unit tests and pushed the changes to #742 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The requirement for sqlparse to be less than 0.3.0 breaks this given the recent release of sqlparse 0.3.0 recently.
https://github.com/andialbrecht/sqlparse/blob/master/CHANGELOG
Checklist
changelog.md.AUTHORSfile (or it's already there).