Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to sqlparse 0.3.0 #1052

Merged
merged 6 commits into from
May 6, 2019
Merged

Upgrade to sqlparse 0.3.0 #1052

merged 6 commits into from
May 6, 2019

Conversation

amjith
Copy link
Member

@amjith amjith commented May 6, 2019

No description provided.

@amjith amjith requested a review from j-bennet May 6, 2019 16:13
@codecov-io
Copy link

codecov-io commented May 6, 2019

Codecov Report

Merging #1052 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1052      +/-   ##
==========================================
- Coverage   84.67%   84.59%   -0.09%     
==========================================
  Files          21       21              
  Lines        2492     2492              
==========================================
- Hits         2110     2108       -2     
- Misses        382      384       +2
Impacted Files Coverage Δ
pgcli/packages/sqlcompletion.py 97.67% <100%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30c7889...8b14029. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #1052 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1052      +/-   ##
==========================================
- Coverage   84.67%   84.59%   -0.09%     
==========================================
  Files          21       21              
  Lines        2492     2492              
==========================================
- Hits         2110     2108       -2     
- Misses        382      384       +2
Impacted Files Coverage Δ
pgcli/packages/sqlcompletion.py 97.67% <100%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30c7889...8b14029. Read the comment docs.

@amjith amjith merged commit 5806399 into master May 6, 2019
@amjith amjith deleted the pr1047 branch May 6, 2019 18:12
uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request May 28, 2019
pgcli depends on sqlparse<0.3.0,>=0.2.2, and sqlparse was updated to 0.3.0
in ports r495481.

pgcli depends on psycopg2>=2.7.4,<2.8, and psycopg2 was updated to 2.8.2
in ports r502646.

These broke run time, with the following error(s)

  raise DistributionNotFound(req, requirers)
  pkg_resources.DistributionNotFound: The 'sqlparse<0.3.0,>=0.2.2' distribution was not found and is required by pgcli

  raise DistributionNotFound(req, requirers)
  pkg_resources.DistributionNotFound: The 'psycopg2>=2.7.4,<2.8' distribution was not found and is required by pgcli

Upstream upgraded sqlparse support to include 0.3.0 in PR #1052 [1], this
change backports that PR accordingly.

Upstream has an open PR to unpin psycopg2 [2][3] but it needs to be updated
to use psycopg2 (not psycopg2-binary) in install_requires.

This change patches out the psycopg2 max version. The test results shows
no test failure delta with 2.8.2 over 2.7.7 (the version before ports
r502646).

While I'm here:

  - Declare pinned (maximum) RUN_DEPENDS versions according to setup.py
    to pick these issues up earlier during QA (max versions not being
    satisfied will error out during dependency builds/verification
    pre-commit

[1] dbcli/pgcli#1052
[2] dbcli/pgcli#1059
[3] dbcli/pgcli#1036

PR:		238182
Reported by:	Marcin Cieślak <saper saper info>
Approved by:	portmgr (blanket: run time fix, just fix it)


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@502867 35697150-7ecd-e111-bb59-0022644237b5
uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request May 28, 2019
pgcli depends on sqlparse<0.3.0,>=0.2.2, and sqlparse was updated to 0.3.0
in ports r495481.

pgcli depends on psycopg2>=2.7.4,<2.8, and psycopg2 was updated to 2.8.2
in ports r502646.

These broke run time, with the following error(s)

  raise DistributionNotFound(req, requirers)
  pkg_resources.DistributionNotFound: The 'sqlparse<0.3.0,>=0.2.2' distribution was not found and is required by pgcli

  raise DistributionNotFound(req, requirers)
  pkg_resources.DistributionNotFound: The 'psycopg2>=2.7.4,<2.8' distribution was not found and is required by pgcli

Upstream upgraded sqlparse support to include 0.3.0 in PR #1052 [1], this
change backports that PR accordingly.

Upstream has an open PR to unpin psycopg2 [2][3] but it needs to be updated
to use psycopg2 (not psycopg2-binary) in install_requires.

This change patches out the psycopg2 max version. The test results shows
no test failure delta with 2.8.2 over 2.7.7 (the version before ports
r502646).

While I'm here:

  - Declare pinned (maximum) RUN_DEPENDS versions according to setup.py
    to pick these issues up earlier during QA (max versions not being
    satisfied will error out during dependency builds/verification
    pre-commit

[1] dbcli/pgcli#1052
[2] dbcli/pgcli#1059
[3] dbcli/pgcli#1036

PR:		238182
Reported by:	Marcin Cieślak <saper saper info>
Approved by:	portmgr (blanket: run time fix, just fix it)
swills pushed a commit to swills/freebsd-ports that referenced this pull request May 28, 2019
pgcli depends on sqlparse<0.3.0,>=0.2.2, and sqlparse was updated to 0.3.0
in ports r495481.

pgcli depends on psycopg2>=2.7.4,<2.8, and psycopg2 was updated to 2.8.2
in ports r502646.

These broke run time, with the following error(s)

  raise DistributionNotFound(req, requirers)
  pkg_resources.DistributionNotFound: The 'sqlparse<0.3.0,>=0.2.2' distribution was not found and is required by pgcli

  raise DistributionNotFound(req, requirers)
  pkg_resources.DistributionNotFound: The 'psycopg2>=2.7.4,<2.8' distribution was not found and is required by pgcli

Upstream upgraded sqlparse support to include 0.3.0 in PR #1052 [1], this
change backports that PR accordingly.

Upstream has an open PR to unpin psycopg2 [2][3] but it needs to be updated
to use psycopg2 (not psycopg2-binary) in install_requires.

This change patches out the psycopg2 max version. The test results shows
no test failure delta with 2.8.2 over 2.7.7 (the version before ports
r502646).

While I'm here:

  - Declare pinned (maximum) RUN_DEPENDS versions according to setup.py
    to pick these issues up earlier during QA (max versions not being
    satisfied will error out during dependency builds/verification
    pre-commit

[1] dbcli/pgcli#1052
[2] dbcli/pgcli#1059
[3] dbcli/pgcli#1036

PR:		238182
Reported by:	Marcin Cieślak <saper saper info>
Approved by:	portmgr (blanket: run time fix, just fix it)


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@502867 35697150-7ecd-e111-bb59-0022644237b5
Jehops pushed a commit to Jehops/freebsd-ports-legacy that referenced this pull request May 28, 2019
pgcli depends on sqlparse<0.3.0,>=0.2.2, and sqlparse was updated to 0.3.0
in ports r495481.

pgcli depends on psycopg2>=2.7.4,<2.8, and psycopg2 was updated to 2.8.2
in ports r502646.

These broke run time, with the following error(s)

  raise DistributionNotFound(req, requirers)
  pkg_resources.DistributionNotFound: The 'sqlparse<0.3.0,>=0.2.2' distribution was not found and is required by pgcli

  raise DistributionNotFound(req, requirers)
  pkg_resources.DistributionNotFound: The 'psycopg2>=2.7.4,<2.8' distribution was not found and is required by pgcli

Upstream upgraded sqlparse support to include 0.3.0 in PR #1052 [1], this
change backports that PR accordingly.

Upstream has an open PR to unpin psycopg2 [2][3] but it needs to be updated
to use psycopg2 (not psycopg2-binary) in install_requires.

This change patches out the psycopg2 max version. The test results shows
no test failure delta with 2.8.2 over 2.7.7 (the version before ports
r502646).

While I'm here:

  - Declare pinned (maximum) RUN_DEPENDS versions according to setup.py
    to pick these issues up earlier during QA (max versions not being
    satisfied will error out during dependency builds/verification
    pre-commit

[1] dbcli/pgcli#1052
[2] dbcli/pgcli#1059
[3] dbcli/pgcli#1036

PR:		238182
Reported by:	Marcin Cieślak <saper saper info>
Approved by:	portmgr (blanket: run time fix, just fix it)


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@502867 35697150-7ecd-e111-bb59-0022644237b5
svmhdvn pushed a commit to svmhdvn/freebsd-ports that referenced this pull request Jan 10, 2024
pgcli depends on sqlparse<0.3.0,>=0.2.2, and sqlparse was updated to 0.3.0
in ports r495481.

pgcli depends on psycopg2>=2.7.4,<2.8, and psycopg2 was updated to 2.8.2
in ports r502646.

These broke run time, with the following error(s)

  raise DistributionNotFound(req, requirers)
  pkg_resources.DistributionNotFound: The 'sqlparse<0.3.0,>=0.2.2' distribution was not found and is required by pgcli

  raise DistributionNotFound(req, requirers)
  pkg_resources.DistributionNotFound: The 'psycopg2>=2.7.4,<2.8' distribution was not found and is required by pgcli

Upstream upgraded sqlparse support to include 0.3.0 in PR #1052 [1], this
change backports that PR accordingly.

Upstream has an open PR to unpin psycopg2 [2][3] but it needs to be updated
to use psycopg2 (not psycopg2-binary) in install_requires.

This change patches out the psycopg2 max version. The test results shows
no test failure delta with 2.8.2 over 2.7.7 (the version before ports
r502646).

While I'm here:

  - Declare pinned (maximum) RUN_DEPENDS versions according to setup.py
    to pick these issues up earlier during QA (max versions not being
    satisfied will error out during dependency builds/verification
    pre-commit

[1] dbcli/pgcli#1052
[2] dbcli/pgcli#1059
[3] dbcli/pgcli#1036

PR:		238182
Reported by:	Marcin Cieślak <saper saper info>
Approved by:	portmgr (blanket: run time fix, just fix it)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants