Add --log-file & \log-file option to always capture output #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@saucoide This can be useful, sure. Go ahead with the PR. Thank you! |
j-bennet
reviewed
Apr 27, 2024
j-bennet
reviewed
Apr 27, 2024
j-bennet
reviewed
Apr 27, 2024
j-bennet
reviewed
Apr 27, 2024
Currently outputting to a file via \o disables the console output This patch adds a `--log-file` cli arg with similar behavior to `psql`* and a \log-file special command to enable/disable it from the console *https://www.postgresql.org/docs/current/app-psql.html#APP-PSQL-OPTION-LOG-FILE
Co-authored-by: Irina Truong <637013+j-bennet@users.noreply.github.com>
Co-authored-by: Irina Truong <637013+j-bennet@users.noreply.github.com>
Co-authored-by: Irina Truong <637013+j-bennet@users.noreply.github.com>
|
Thank you @saucoide |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently outputting to a file via \o disables the console output, however i often find
myself wanting to both log the results & see them in the terminal too #1424
This patch would add a cli arg
--log-file, behaving as the same option inpsql* + a\log-file special command to enable/disable it from the console
* https://www.postgresql.org/docs/current/app-psql.html#APP-PSQL-OPTION-LOG-FILE
Maybe this is just useful for me and not worth adding but thought i'd submit it anyway,
i'll update changelog, etc later if you decide it's ok to merge
Checklist
changelog.rst.AUTHORSfile (or it's already there).pip install pre-commit && pre-commit install), and ranblackon my code.