Make it possible to use SSL with pgcli #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmolck
force-pushed
the
pgcli-ssl-url-support
branch
2 times, most recently
from
7486bb6
to
e52cb9c
Compare
added 2 commits
May 25, 2017 14:49
This adds support for additional url query params which make stuff like ``` pgcli "postgres://user:pass@host.invalid/db?\ sslmode=verify-full&sslcert=my.pem&sslkey=my-key.pem&sslrootcert=ca.pem" ``` work. More generally it allows one to pass through various extra connection options.
aschmolck
force-pushed
the
pgcli-ssl-url-support
branch
from
e52cb9c
to
52e47f3
Compare
Codecov Report
@@ Coverage Diff @@
## master #721 +/- ##
========================================
+ Coverage 79.96% 80% +0.04%
========================================
Files 22 22
Lines 2545 2551 +6
========================================
+ Hits 2035 2041 +6
Misses 510 510
Continue to review full report at Codecov.
|
|
Looks great! Thank you for your contribution and thanks for taking the time to add tests. 🍨 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds support for additional url query params which make stuff like
work. More generally it allows one to pass through various extra connection
options.
Checklist
changelog.md.AUTHORSfile (or it's already there).